Qtopia-interest Archive, March 2008
[PATCH] Another day, another excitment
Message 1 in thread
Hey,
I have started reading the CallScreen code and stumbled across the following.
havePhoto get's initialized with false, if no photo is found false is assigned
and otherwise it is only read. So why do you go through the hassle of looking
for a picture? Is the code dead by default or is this is a bug?
z.
From 9fe1490eea3c7e593d95400d12f1d1b31921961b Mon Sep 17 00:00:00 2001
From: Holger Freyther <zecke@xxxxxxxxxxx>
Date: Tue, 4 Mar 2008 11:32:57 +0100
Subject: [PATCH] Actually set havePhoto to true when we have a photo...
---
src/server/phone/callscreen.cpp | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/server/phone/callscreen.cpp b/src/server/phone/callscreen.cpp
index 3d9c7cc..9c44135 100644
--- a/src/server/phone/callscreen.cpp
+++ b/src/server/phone/callscreen.cpp
@@ -100,6 +100,7 @@ public:
havePhoto = false;
} else {
photo =
Qtopia::applicationFileName( "addressbook", "contactimages/" ) +
cnt.portraitFile();
+ havePhoto = QFile::exists(photo);
}
}
}
--
[ signature omitted ]
Message 2 in thread
On Tuesday 04 March 2008 11:41:00 Holger Freyther wrote:
> Hey,
> I have started reading the CallScreen code and stumbled across the
> following.
and probably it should be hasPhoto instead of havePhoto?
z.
--
[ signature omitted ]
