Qtopia-interest Archive, April 2008
Questions regarding ficgta01audioplugin.cpp
Message 1 in thread
Hey,
I currently review the above file and see code like the two examples below. I
wonder what was the intended thing. It is late and I'm tired but these look
fairly similar. Comments appreciated. I also see QtopicIpc.. code after
return statements, what is the reasoning there?
z.
Code Samples:
if (m_isPhone) {
mode = 3;
} else
mode = 3;
if (m_isPhone) {
QtopiaIpcEnvelope
e("QPE/AudioVolumeManager/Ficgta01VolumeService", "setAmp(QString)");
e << QString("Stereo Speakers + Headphones");
} else {
QtopiaIpcEnvelope
e("QPE/AudioVolumeManager/Ficgta01VolumeService", "setAmp(QString)");
e << QString("Stereo Speakers + Headphones");
}
--
[ signature omitted ]
Message 2 in thread
Holger Freyther wrote:
> Hey,
>
> I currently review the above file and see code like the two examples below. I
> wonder what was the intended thing. It is late and I'm tired but these look
> fairly similar. Comments appreciated. I also see QtopicIpc.. code after
> return statements, what is the reasoning there?
>
> z.
>
> Code Samples:
>
> if (m_isPhone) {
> mode = 3;
> } else
> mode = 3;
>
>
> if (m_isPhone) {
> QtopiaIpcEnvelope
> e("QPE/AudioVolumeManager/Ficgta01VolumeService", "setAmp(QString)");
> e << QString("Stereo Speakers + Headphones");
> } else {
> QtopiaIpcEnvelope
> e("QPE/AudioVolumeManager/Ficgta01VolumeService", "setAmp(QString)");
> e << QString("Stereo Speakers + Headphones");
> }
>
>
Thats just my experimenting with turning off the amp when not needed, for power management.
I determined it was cool, but not usually what the user wanted. I think I disabled the other half
off the code.
It's safe to discard.
--
[ signature omitted ]